Add BC OrgBook and BC Geocoder Lookups to SHAS Intake Form #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
wilwong89
force-pushed
the
feature/orgbook-address-lookup
branch
from
47a4f72 to
8081f78
Compare
kyle1morel
reviewed
Jun 3, 2024
Comment on lines
105
to
+107
| function confirmSubmit(data: any) { | ||
| const tempData = Object.assign({}, data); | ||
| delete tempData['addressSearch']; |
There was a problem hiding this comment.
Just a mental note, not something to be done, its tech-debty - but we should be creating form submission types to avoid using any on submits.
wilwong89
force-pushed
the
feature/orgbook-address-lookup
branch
from
8081f78 to
d36213e
Compare
kyle1morel
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusted intake form to search OrgBook and Geocoder APIs for BC registered businesses and addresses.
Add new ENV variables for API
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments